paradigmxyz / revm-inspectors

EVM Execution Hooks.
Apache License 2.0
183 stars 71 forks source link

feature(writer): add support for external decoded data sources #151

Closed zerosnacks closed 4 months ago

zerosnacks commented 4 months ago

Closes: https://github.com/paradigmxyz/revm-inspectors/issues/14

decoded.contract_name has not been added as a field as it is only used in Foundry's gas report, not in the current trace render.

It is likely that some stylistic updates will be followed up relatively quickly

Related PR: https://github.com/foundry-rs/foundry/pull/8224

zerosnacks commented 4 months ago

Re-marking this as draft until print traces pass again https://github.com/foundry-rs/foundry/actions/runs/9617990642/job/26530949144?pr=8224

Still, open for feedback

zerosnacks commented 4 months ago

Formatting has been fixed, Foundry tests are now passing: https://github.com/foundry-rs/foundry/pull/8224

DaniPopes commented 4 months ago

Can you add tests here too? Using expect!, with also decoded fields

zerosnacks commented 4 months ago

Can you add tests here too? Using expect!, with also decoded fields

Added, please note that it shows the application of patches, not necessarily the full decoding as implemented in Foundry