search

paradigmxyz / revm-inspectors

EVM Execution Hooks.
Apache License 2.0
171 stars 55 forks source link

Add support for `JS` tracer to `muxTracer` #58

Open ArtificialPB opened 6 months ago

ArtificialPB commented 6 months ago

Follow-up of https://github.com/paradigmxyz/evm-inspectors/pull/57, currently muxTracer supports only built-in tracers. It should also support JS tracers.

In the alloy-rs tracing crate, the MuxConfig and MuxFrame types will need to have map key changed to GethDebugTracerType. Changes in this project should be pretty much the same, with addition of supporting the JSInspector via DelegatingInspector. Changes in reth are probably not needed.

The JSInspector is under js-tracer feature, so a feature gate for it in MuxInspector will need to be added as well.

mattsse commented 6 months ago

@ArtificialPB I'll need to bump evm-inspectors on reth shortly, so if you find the time I'd appreciate a pr that adds the missing ::Mux handler for debug_trace* etc:

https://github.com/paradigmxyz/reth/blob/e21304947b6a46ba524d4b1e68351b05587d8892/crates/rpc/rpc/src/debug.rs#L279-L279

https://github.com/paradigmxyz/reth/blob/e21304947b6a46ba524d4b1e68351b05587d8892/crates/rpc/rpc/src/debug.rs#L512-L512

ArtificialPB commented 6 months ago

@mattsse yeah, just opened it about an hour ago: https://github.com/paradigmxyz/reth/pull/7053

mattsse commented 6 months ago

ah amazing! ty