search

paradigmxyz / revm-inspectors

EVM Execution Hooks.
Apache License 2.0
185 stars 71 forks source link

Don't consume `self` in `ParityTraceBuilder` where possible #59

Closed DaniPopes closed 1 month ago

DaniPopes commented 8 months ago

There is no need to and we want to maintain ownership of the struct after in Reth

nkysg commented 2 months ago

Do you mean this func https://github.com/paradigmxyz/revm-inspectors/blob/7e31e4fc7692e3f3216473c7116ff4a3453d9d00/src/tracing/builder/parity.rs#L265-L265

Thx @DaniPopes

mattsse commented 1 month ago

turns out we can't easily do this because for parity, we always consume