paradigmxyz / rivet

Developer Wallet & DevTools for Anvil
MIT License
832 stars 71 forks source link

Feature: Modify transaction request data #46

Closed jxom closed 1 year ago

jxom commented 1 year ago

The Request

The ability to modify transaction request data (fees, gas, calldata, etc) on the "Pending Request" screen.

Problem

As a user, when I send a transaction from a Dapp, the "Pending Request" screen pops up in Rivet, but from within that screen, there is no way to modify data such as: fees per gas, gas limit, calldata, sender/receiver addresses, etc.

Solution

As a user, from the "Pending Request" screen, I would like the ability to modify the:

vishkrish200 commented 1 year ago

hey, I would like to work on this. either of these is doable but would like to which approach is preferred :) I have two approaches in mind,

jxom commented 1 year ago

Think the first point would be good! Let's make sure there are no layout shifts when the text turns into an input field.

@achalvs – do you have any opinions with design here?

vishkrish200 commented 1 year ago

@jxom do i just go ahead with the edit button? to avoid text shifting we could do it as a popover?

jxom commented 1 year ago

@vishkrish200 – yep, we can do that for now. We may probably need a Popover component, akin to our current Tooltip component.

vishkrish200 commented 1 year ago

yep @jxom radix-ui already has a pretty nice popover component ready. https://www.radix-ui.com/themes/docs/components/popover

Can use this for now

MimmyJau commented 1 year ago

hey @jxom @vishkrish200! i noticed there hasn't been much activity on this issue recently.

mind if i take a crack at it? if you're still working on it though, no worries.

jxom commented 1 year ago

@MimmyJau - go for it! Mind if I assign you to the issue?

MimmyJau commented 1 year ago

@jxom yes please!