search

paragi / sphp

A snappy PHP execution module / middleware
46 stars 14 forks source link

Option A: Minimal needed changes to get Windows-compatibility #10

Closed Apollon77 closed 6 years ago

Apollon77 commented 6 years ago

Please check and accept the testing commit first. Or only accept this one, but follow things described there first!!

This PR contains the minimum fix needed to get Windows-compatibilty. The reason is Line 73 of sphp.js where you search the last "/" in the path ... on windows it is the other separator :-) I replaced it with "path.sep" and it worked. Other changes are only whitespace stuff my IDE did (sorry for that) when saving.

With this testing also get green in appveyor: https://ci.appveyor.com/project/Apollon77/sphp/build/test-13

Apollon77 commented 6 years ago

Great, then I close this PR :-)