Closed praveingk closed 5 months ago
For the detailed report, please go to Checks tab
, click Build and Test
, and then download unit_test_coverage
artifact at the bottom of build page.
The coverage result does not include the functional test results.
I am still testing in my local env.
For the detailed report, please go to Checks tab
, click Build and Test
, and then download unit_test_coverage
artifact at the bottom of build page.
The coverage result does not include the functional test results.
I have tested it in my local env using act, and it works.
@praveingk This is great! A few concerns before I stamp.
- Seems like this workflow is triggered on a tag push to the main branch. Do we need any tag protection rules to ensure only maintainers can push tags to the main branch?
- There's also concerns of tags on other branches triggering this type of workflow. Can we double check and make sure this doesn't happen or ensure it's not really an issue?
- Have you tested the actual binaries that have been created?
@praveingk This is great! A few concerns before I stamp.
- Seems like this workflow is triggered on a tag push to the main branch. Do we need any tag protection rules to ensure only maintainers can push tags to the main branch?
Yes, we will need to check and add protection rules if its not already present
- There's also concerns of tags on other branches triggering this type of workflow. Can we double check and make sure this doesn't happen or ensure it's not really an issue?
I have changed the "on" action to push on main branch. I am unable to test it out in my local env though.
- Have you tested the actual binaries that have been created?
I had used act to test the artifacts, and the binaries worked.
For the detailed report, please go to Checks tab
, click Build and Test
, and then download unit_test_coverage
artifact at the bottom of build page.
The coverage result does not include the functional test results.
For the detailed report, please go to Checks tab
, click Build and Test
, and then download unit_test_coverage
artifact at the bottom of build page.
The coverage result does not include the functional test results.
@seankimkdy @praveingk I created a tag protection rule that (for now) requires maintainers to push, modify, or delete all tags. We can weaken this later if needed.
Unit Test Results
269 tests ±0 269 :white_check_mark: ±0 3s :stopwatch: ±0s 50 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 1b542dad. ± Comparison against base commit e9ad4633.
:recycle: This comment has been updated with latest results.