search

paraglider-project / paraglider

Streamlining cloud networking
https://paragliderproject.io
Apache License 2.0
61 stars 4 forks source link

[Azure] Implement `GetResourceSubnetsAddress` #393

Open Cohen-J-Omer opened 2 months ago

Cohen-J-Omer commented 2 months ago

Since IBM's VPN implementation doesn't involve BGP peering, it and the party it is set to connect with, are required to exchange their network's address spaces. During PR#334 I was asked to expend the shared address space to incorporate the entire VPC/VNet containing the address space in CreateVpnGatewayRequest.AddressSpace. For that purpose I added the GetNetworkAddressSpaces method to the CloudPlugin interface and implemented it for the IBM plugin. However, Azure's GetNetworkAddressSpaces contains a placeholder implementation, which handles an IP address by translating it to a CIDR. Instead, as documented in the function, this method is supposed to:

divega commented 1 month ago

@Cohen-J-Omer is this something that is blocking IBM Cloud to Azure integration or is there any other criteria we should tackle it soon or can it be in the backlog?

Cohen-J-Omer commented 1 month ago

Hey @divega, The temporary Azure implementation integrated well with IBM at the time the PR was live (multicloud test passed), so unless the situation was changed by new commits, I don't think it's urgent.

divega commented 1 month ago

Thank. Moving to backlog then.