Deep Static Analysis and Unit Testing

[paragonie-scott]

We currently have Psalm running in Travis CI on the core files (src/Engine). We should expand the coverage include everything in src. We'll have to do each Cabin individually.

[muglug]

Relatedly, this curious chunk of code was flagged by latest Psalm dev-master.

[paragonie-scott]

Oh, I should probably change null to []? (Composer still hasn't updated.)

[muglug]

more the if (!\is_array($data)) { check on something that is definitely an array (because of the cast)

[paragonie-scott]

Is there any chance we can just make the is_*() functions excluded from type errors?

[muglug]

They should be excluded when the type comes from a docblock (as opposed to language-level check). I think the difference here is that the if is inside a loop, and I imagine I introduced a regression with https://github.com/vimeo/psalm/pull/115. Will fix momentarily.

But still, how can that if statement ever be true?

[paragonie-scott]

It can't ever be true; it's dead code. I'm removing it in a few seconds. :)

[muglug]

Fixed in https://github.com/vimeo/psalm/commit/f0964685362dc45e867a6e22de3b4fc28b3a4f6a

[paragonie-scott]

Left to do before this can be closed (mostly meant as a note to myself so the next time I look through open issues for things to work on, I don't need to try to refresh my own memory):

• [x] Find out if Psalm can be coerced into specifying a different .xml file from its CLI arguments.
  • [ ] If yes, create a psalm.xml for each Cabin.
  • [ ] If no, rename the existing psalm.xml file and rapidly create/remove symlinks to make it behave. Also, create a psalm.sh script to facilitate this for non-Travis testing.

[muglug]

You can do psalm --config=somefile.xml

[paragonie-scott]

Perfect! Thanks. :)

[muglug]

If you're running --diff builds locally you'll need to specify different cache directories for them, but I think your codebase is small enough that --diff builds aren't necessary.