This DOES NOT change the web server to Caddy, as was suggested in #60. My hope is that this is at least a marginal (but useful!) improvement that makes the docker-compose setup useful until I or someone else can get the caddy install stuff worked into the build process.
Made base image Ubuntu 17.10
Changed packages to install for PHP 7.2
Removed libsodium install stuff (now in 7.2 core)
Removed redundant apt installs of composer (2nd was a NOP)
Removed installs of git and wget (not used anymore)
Removed install of php-dev
Reason: don't need to compile sodium and the number of
deps it wasted time installing was ridiculous
Removed redundant call to a2enmod rewrite
Change apache run command arg to -DFOREGROUND
In testing, -D FOREGROUND still resulted in apache exiting
One concern I have is that I see the Travis file still installs libsodium and php7.2-sodium. The sodium extension was showing as installed by default and libsodium appeared to be getting fetched from ondrej's PPA during the image build process. So I'm not sure if I'm missing something or if it's just a difference in environment that accounts for the differences in configuration.
Issues Addressed (Optional)
171
Contributor Agreement (Required)
I am submitting this pull request under one or more of the following
licenses:
Furthermore, I understand that CMS Airship is released under the GNU Public
License to the general public, as well as private commercial licenses
(purchasable from Paragon Initiative Enterprises).
By submitting this pull request, I acknowledge that my contribution will be
incorporated into CMS Airship, and consent for it to be handled as outlined
above.
(This does not in any way restrict your rights to use your own modifications.
The purpose of this agreement is to maximize awareness and transparency.)
Labels Requested
Feel free to list any labels you feel are appropriate for this issue,
and a member of the Airship core team will apply them as soon as
possible.
Summary
This DOES NOT change the web server to Caddy, as was suggested in #60. My hope is that this is at least a marginal (but useful!) improvement that makes the docker-compose setup useful until I or someone else can get the caddy install stuff worked into the build process.
One concern I have is that I see the Travis file still installs libsodium and php7.2-sodium. The
sodiumextension was showing as installed by default and libsodium appeared to be getting fetched from ondrej's PPA during the image build process. So I'm not sure if I'm missing something or if it's just a difference in environment that accounts for the differences in configuration.Issues Addressed (Optional)
171
Contributor Agreement (Required)
I am submitting this pull request under one or more of the following licenses:
Furthermore, I understand that CMS Airship is released under the GNU Public License to the general public, as well as private commercial licenses (purchasable from Paragon Initiative Enterprises).
By submitting this pull request, I acknowledge that my contribution will be incorporated into CMS Airship, and consent for it to be handled as outlined above.
(This does not in any way restrict your rights to use your own modifications. The purpose of this agreement is to maximize awareness and transparency.)
Labels Requested
Feel free to list any labels you feel are appropriate for this issue, and a member of the Airship core team will apply them as soon as possible.
Dockerenhancement