Resolve publish issues in MySQL

[vzool]

also fixes #32 😘

[paragonie-scott]

By the way, you can just use $db->getDriver() instead of parsing out the DSN.

[vzool]

Aha okey 😃

[vzool]

By the way, you can just use $db->getDriver() instead of parsing out the DSN.

Done 😋

[vzool]

I love green signs 😍 Do you prefer to make all these modifications in one commit? 🙃

[paragonie-scott]

Wait, how'd you get the tests to pass with the void return type? That seems off.

[vzool]

Wait, how'd you get the tests to pass with the void return type? That seems off.

Yes, of course. This is odd for PHP realm. But, it is totally fine for C/C++ realm. Because, I'm a C/C++ developer from the beginning then I became a PHP developer and when tests complaints about the return types, I'm a very aware of return types and casting. So, I search for what is available for PHP.

Finally, I found it here which is clear that PHP is supporting void as a return type.

Thanks for asking ^_^

[vzool]

Yes, of course. This is odd for PHP realm. But, it is totally fone for C/C++ realm. Because, I'm a C/C++ developer from the beginning then I became a PHP developer and when tests complaints about the return types, I'm a very aware of return types and casting. So, I search for what is available for PHP.

Finally, I found it here which is clear that PHP is supporting void as a return type.

Thanks for asking ^_^

On Mon, Oct 22, 2018, 5:54 AM Scott notifications@github.com wrote:

Wait, how'd you get the tests to pass with the void return type? That seems off.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/paragonie/chronicle/pull/36#issuecomment-431729403, or mute the thread https://github.com/notifications/unsubscribe-auth/AEuSoHmdPt74iOCZFCBNPI-soyDChgKSks5unTNXgaJpZM4Xym4g .

[paragonie-scott]

Sorry for being unclear: The problem is that Chronicle supports PHP 7.0 and the void return type didn't land until 7.1.

[vzool]

Aha, maybe it was there since 7.0 but not documented until 7.1 🤔

[paragonie-scott]

Nope. I think it's treating it like a class return hint. Interesting.

[paragonie-scott]

I'll remove the type hint but keep the docblock. Thanks a lot! :)

[vzool]

You're welcome, I'm still looking for types directory at php-src 😆