paragonie / halite

High-level cryptography interface powered by libsodium
https://paragonie.com/project/halite
Mozilla Public License 2.0
1.13k stars 85 forks source link

Remove access modifier final from private methods (PHP 8 support) #158

Closed junaidbinfarooq closed 3 years ago

junaidbinfarooq commented 3 years ago

Removes access modifier final from private methods as such methods are never overridden by other classes.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 783


Totals Coverage Status
Change from base Build 782: 0.0%
Covered Lines: 509
Relevant Lines: 1334

💛 - Coveralls
spaze commented 3 years ago

Just a heads up that this solves a new PHP 8.0 warning:

Warning: Private methods cannot be final as they are never overridden by other classes

See https://3v4l.org/rl4ti

junaidbinfarooq commented 3 years ago

Just a heads up that this solves a new PHP 8.0 warning:

Warning: Private methods cannot be final as they are never overridden by other classes

See https://3v4l.org/rl4ti

Well, that is what I exactly tried to fix. :)

spaze commented 3 years ago

Well, that is what I exactly tried to fix. :)

Just adding a context so the maintainer can prioritize properly.

spaze commented 3 years ago

Hey @paragonie-security, can you please merge this and prepare a new release to support PHP 8.0? Thank you! :-)

junaidbinfarooq commented 3 years ago

Anyone merging this PR? @paragonie-security?

spaze commented 3 years ago

@paragonie-scott @paragonie-staff Any chance of merging this soon for flawless PHP 8 support? Thanks!