search

paragonie / paseto

Platform-Agnostic Security Tokens
https://paseto.io
Other
3.24k stars 108 forks source link

[WIP] Initial stab at refactor #18

Closed carnage closed 6 years ago

carnage commented 6 years ago

Started to make the token object immutable.

paragonie-scott commented 6 years ago

Immutability is a good idea. 👍

paragonie-scott commented 6 years ago

I think I'm going to implement where this pull request was going, except with the new local/remote paradigm.

carnage commented 6 years ago

I was using this as a reference https://github.com/lcobucci/jwt/blob/master/src/Token/Plain.php for refactoring efforts

paragonie-scott commented 6 years ago

The code has diverged pretty significantly since this PR was started. I liked the idea you proposed, but since the merge conflicts keep stacking up I'm going to close it. Thanks @carnage for the immutability suggestion. 👍