search

paragonie / paseto

Platform-Agnostic Security Tokens
https://paseto.io
Other
3.24k stars 108 forks source link

Rename "publickey" to "tokenkey" in readme #2

Closed carnage closed 6 years ago

carnage commented 6 years ago

The term public key as used in the token specification is slightly confusing, I'd suggest renaming it to token key to better reflect it's usage.

eg

version.purpose.tokenkey.ciphertext

paragonie-scott commented 6 years ago

tokenkey might confuse people who do key identifiers too, though. (Tracking this feature request in #1)

Y'know how sodium_crypto_box_seal() prefixes the ephemeral public key, but the rest of it's basically sodium_crypto_box()? That prefixed public key is what we're doing here. Maybe one-time-key would work better?

carnage commented 6 years ago

It is what you are doing in protocol V2, but in V1 it is an RSA encrypted one-time random key.

one-time-key may work best, has the side effect of promoting that it shouldn't be reused :p

paragonie-scott commented 6 years ago

https://github.com/paragonie/past/commit/8eca298b1c2613d0d4ea54cec6ab41574bd8e06c :)

paragonie-scott commented 6 years ago

I forgot to press "close issue", but that's a better mistake than the converse (closing issues by accident, which could be received as rude).