paragonie / random_compat

PHP 5.x support for random_bytes() and random_int()
https://paragonie.com/projects
MIT License
8.16k stars 145 forks source link

please remove v9.99.99 #146

Closed smecnarowski closed 6 years ago

smecnarowski commented 6 years ago

Thanks a lot :)

jcoby commented 6 years ago

This seems to be on purpose. See https://github.com/paragonie/random_compat/commit/35469243ebbb9be5086cff57538cac6da2c36852

Which later got re-versioned to v9.99.99.

And the code is a noop in the branch: https://github.com/paragonie/random_compat/tree/v9.99.99

paragonie-scott commented 6 years ago

Correct. We will not be removing v9.99.99.

paragonie-scott commented 6 years ago

https://github.com/paragonie/random_compat#version-99999 - Please read this if you are encountering problems due to the existence of v9.99.99.

smecnarowski commented 6 years ago

I'm Sorry for this misunderstanding, - now i see that this is required for ramsey/uuid and v 9.99.99 is in their composer.json https://github.com/ramsey/uuid/blob/3.x/composer.json

paragonie-scott commented 6 years ago

Permanent link:

https://github.com/ramsey/uuid/blob/d09ea80159c1929d75b3f9c60504d613aeb4a1e3/composer.json#L29

This is correct: The library is permitting v9.99.99 or v2.x or v1.x. It's equivalent to >= 1.

If you're creating your composer.lock on PHP 7 but deploying it on PHP 5, you'll probably run into incompatibility issues. Workaround: Explicitly use >=1 <9 or >=2 <9 in your own project's composer.json file.