addZoomListener in GraphicalView class Pinch zoom issue

paragp / achartengine

AChartEngine is a charting library for Android applications. It currently supports the following chart types: line chart area chart scatter chart time chart bar chart pie chart bubble chart doughnut chart range (high-low) bar chart dial chart / gauge combined (any combination of line, cubic line, scatter, bar, range bar, bubble) chart cubic line chart All the above supported chart types can contain multiple series, can be displayed with the X axis horizontally (default) or vertically and support many other custom features. The charts can be built as a view that can be added to a view group or as an intent, such as it can be used to start an activity. The model and the graphing code is well optimized such as it can handle and display huge number of values. AChartEngine is currently at the 1.0.0 release. New chart types will be added in the following releases. Please keep sending your feedback such as we can continually improve this library. Find us on Facebook, too: http://www.facebook.com/achartengine Read a short introduction to AChartEngine here: http://www.javaadvent.com/2012/12/achartengine-charting-library-for.html Another good tutorial can be read here: http://jaxenter.com/effort-free-graphs-on-android-with-achartengine-46199.html

0 stars 1 forks source link

What steps will reproduce the problem?
1. GraphicalView graph = ChartFactory.getTimeChartView(context, 
                dataset, mRenderer,"HH:mm"); 
2. graph.addZoomListener(listener,false,true) 

What is the expected output? What do you see instead?
I expect to handle events caused by pinch zoom only.
I can't handle any zoom event. 

What version of the product binary library are you using?
achartengine-1.1.0

As I navigated to source code i found this in GraphicalView.class file

public void addZoomListener(ZoomListener listener, boolean onButtons, boolean 
onPinch) 
{
     if(onButtons)
     { 
                if(mZoomIn != null) 
                {  mZoomIn.addZoomListener(listener); 
                    mZoomOut.addZoomListener(listener);
                 }
                if(onPinch) mTouchHandler.addZoomListener(listener);
     }
 }

instead of for example 

public void addZoomListener(ZoomListener listener, boolean onButtons, boolean 
onPinch) 
{
     if(onButtons)
     { 
                if(mZoomIn != null) 
                {  mZoomIn.addZoomListener(listener); 
                    mZoomOut.addZoomListener(listener);
                 }
     }
     if(onPinch) mTouchHandler.addZoomListener(listener);
 }

Additionally - is there a possibility to create method which disables pinch 
zoom only?

Original issue reported on code.google.com by krzyszto...@gmail.com on 12 Dec 2013 at 9:06

paragp / achartengine

addZoomListener in GraphicalView class Pinch zoom issue #379