Closed MrRio closed 6 years ago
CC @buenjybar
Hi, what is the timeframe for this issue?
Edit: I found the fix, i will make a pull request tonight.
getPredictorFromCompression = function getPredictorFromCompression(compression) {
var predictor;
switch (compression) {
case jsPDFAPI.image_compression.FAST:
predictor = 11;
break;
case jsPDFAPI.image_compression.MEDIUM:
predictor = 13;
break;
case jsPDFAPI.image_compression.SLOW:
predictor = 14;
break;
default:
predictor = 12;
break;
}
return predictor;
},
Is this fixed? I am having a similar issue with adobe acrobat reader dc version 2015.017.20053 with the attached file. Thanks. test.pdf
@nnylip Can you send me the image you have embedded? I'll write up a test case!
I've created a test case, it renders fine in Firefox and Chrome, but not Acrobat DC
https://github.com/MrRio/jsPDF/blob/bugfix/png/tests/readers/reference/broken-png-2.pdf
Steps to reproduce:
npm run local-test # run this once
rm ./tests/readers/reference/broken-png-2.pdf
./node_modules/.bin/karma run -- --grep="render transparent PNG"
open -a Adobe\ Acrobat\ Reader\ DC ./tests/readers/reference/broken-png-2.pdf
The test program that created pdf is attached (image is changed as client might object), it uses htm2canvas, also thanks so much for help - Lou
On 10/10/2016 05:00 PM, James Hall wrote:
@nnylip https://github.com/nnylip Can you send me the image embedded? I'll write up a test case!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MrRio/jsPDF/issues/862#issuecomment-252744827, or mute the thread https://github.com/notifications/unsubscribe-auth/APNHCmKoNyeaOsu3D39CQ73Wwfvog2qXks5qyqdUgaJpZM4KJaaE.
Hey @diegocr @jamesbrobb any idea what the issue here might be? Renders ok in Chrome.
Anything happening with this?
Currently looking into it!
Did you check the latest code ?
it seems that it was fixed with #801 & #871
if you replace " <</Predictor undefined " with " <</Predictor 13 "
This issue started happening to me after updating from version 1.2.61 to 1.3.2. PDF is opened in Chrome but not in Adobe Acrobat Reader, gives 110 error. Rolled back to version 1.2.61 solved it for now.
So how can I get this fixed? I am having the same problem @ido172 ?
@edisonramaa i'm also waiting for a fix. i just Installed version 1.2.61 instead of 1.3.2. The error doesn't appear to exist there
Try to download the library from here not by release of NPM, i just used it and it don't create any type of problem with Adobe. The NPM package and the release download have an old version of the library before my PR (#871).
@MrRio should make a new release to fix the problem
@MrRio we're waiting for release, can we help you with this?
Thank you @Pe46dro!
i have overwriten the dist folder of the npm files in node_modules with the ones from https://github.com/MrRio/jsPDF/archive/master.zip then it worked. Thanks @Pe46dro I have one more question, it works on chrome,firefox,but not as expected on safari. On safari it opens the blob in a new tab in the browser with wrong layout, it takes full with and wraps my rows.Is that normal on safari,is there a workaround? This is how it looks in safari:
And this is how it should look(like it does with adobe reader opening the file on chrome or firefox).
@stefanaerts This might be an issue from Safari PDF Reader. The one to trust is the Adobe PDF Reader. if no error is raised at the opening of the file this means the PDF is correct. I will recommend to check with this online tool : https://www.pdf-online.com/osa/validate.aspx if the result is not correct it will be nice if you could share your pdf to dig into the issue.
it's ok,safari works fine.
Hi All, I am facing the similar issue. I have created a Plunkr to demonstrate this issue. I have tried with both the version 1.2.61 and 1.3.2, but both version showing some different behavior. When using 1.2.61, jsPDF not able to render html text content in IE only(Probably due to a image). When using 1.3.2, Adobe is throwing 110 error.
@buenjybar any suggestions.
Thank you @Pe46dro !! Waiting for release.
any update on this issue?
@codeReadyy @robpolak If you're using the latest CDN (1.3.2) you can do the following as a fix.
getPredictorFromCompression = function getPredictorFromCompression(compression) {
var predictor;
switch (compression) {
case jsPDFAPI.image_compression.FAST:
predictor = 11;
break;
case jsPDFAPI.image_compression.MEDIUM:
predictor = 13;
break;
case jsPDFAPI.image_compression.SLOW:
predictor = 14;
break;
default:
predictor = 12;
break;
}
return predictor;
},
Hey still getting the same issue with he latest download of jspdf, looks like that code has been implemented but still receiving error 101 on acrobat reader :(
@Ant248 The current release is missing the default in the switch statement. Use the solution I posted above to fix until the release is updated
Thanks! Odd i have this in my release:
getPredictorFromCompression = function getPredictorFromCompression(compression) { var predictor; switch (compression) { case jsPDFAPI.image_compression.FAST: predictor = 11; break;
case jsPDFAPI.image_compression.MEDIUM:
predictor = 13;
break;
case jsPDFAPI.image_compression.SLOW:
predictor = 14;
break;
default:
predictor = 12;
break;
}
return predictor;
Seems to be what you have posted?
@Ant248 The current release (1.3.3) still have this issue! I just follow @AshKetchumza instructions with previous version (1.3.2) and it works perfectly!
The 110 error comes when you add PNG image on the document
Note: version 1.3.4 doesn't have this PNG compression issue.
Indeed, version 1.3.4 seems to not have this issue.
Then it is officially fixed. :)
See https://github.com/MrRio/jsPDF/pull/852#issuecomment-249667116