Production and Demo no longer properly "Share project using link"

PropGit commented 6 years ago

@MatzElectronics @zfi

On Production, using the Project Details' "Share project using link" feature no longer works. The link provided either returns a "Project Not Found" error, or a "... resource is not available" error:

Here's the link I tried in this example: http://blockly.parallax.com/blockly/projectlink?id=22501&key=1f719d78-0358-4dd3-8cf3-780f466ba2cc

It doesn't matter whether the user trying the link is logged in, or anonymous, and it doesn't matter whether the project is Private or Shared.

On Demo, the behavior is different, but still unsuccessful; it simply returns the user to the home page instead of displaying an error.

MatzElectronics commented 6 years ago

We might be able to fix this in the servlet/daoimpl for "projectlink"

On Wed, Jan 24, 2018 at 9:17 AM, Parallax Git Administrator < notifications@github.com> wrote:

@MatzElectronics https://github.com/matzelectronics @zfi https://github.com/zfi

On Production, using the Project Details' "Share project using link" feature no longer works. The link provided either returns a "Project Not Found" error, or a "... resource is not available" error:

[image: image] https://user-images.githubusercontent.com/1266318/35346401-04e39470-00e7-11e8-8992-e0f2ee1e7a4e.png

Here's the link I tried in this example: http://blockly.parallax.com/ blockly/projectlink?id=22501&key=1f719d78-0358-4dd3-8cf3-780f466ba2cc

It doesn't matter whether the user trying the link is logged in, or anonymous, and it doesn't matter whether the project is Private or Shared.

On Demo, the behavior is different, but still unsuccessful; it simply returns the user to the home page instead of displaying an error.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/1367, or mute the thread https://github.com/notifications/unsubscribe-auth/AS0quKFZlOXY3MF4-npzfRKBis9VKP0tks5tN2WjgaJpZM4RrnND .

MatzElectronics commented 6 years ago

A little more background. There are literally 3 or more copies of the editor littered throughout the filesystem. I've only maintained two of them, but this sharelink is pointing to a third which is calling framec, which is no longer used (so it's been deleted).

On Wed, Jan 24, 2018 at 9:19 AM, Matt Matz mmatz@parallax.com wrote:

We might be able to fix this in the servlet/daoimpl for "projectlink"

Matthew Matz | STEM/Robotics Educator Parallax Inc. | Direct: 916-625-3019 <(916)%20625-3019> | www.parallax.com | @MatzElectronics http://twitter.com/MatzElectronics | Licenses http://www.tspc.oregon.gov/lookup_application/LDisplay_Individual.asp?id=07080L3B270

On Wed, Jan 24, 2018 at 9:17 AM, Parallax Git Administrator < notifications@github.com> wrote:

@MatzElectronics https://github.com/matzelectronics @zfi https://github.com/zfi

On Production, using the Project Details' "Share project using link" feature no longer works. The link provided either returns a "Project Not Found" error, or a "... resource is not available" error:

[image: image] https://user-images.githubusercontent.com/1266318/35346401-04e39470-00e7-11e8-8992-e0f2ee1e7a4e.png

Here's the link I tried in this example: http://blockly.parallax.com/bl ockly/projectlink?id=22501&key=1f719d78-0358-4dd3-8cf3-780f466ba2cc

It doesn't matter whether the user trying the link is logged in, or anonymous, and it doesn't matter whether the project is Private or Shared.

On Demo, the behavior is different, but still unsuccessful; it simply returns the user to the home page instead of displaying an error.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/1367, or mute the thread https://github.com/notifications/unsubscribe-auth/AS0quKFZlOXY3MF4-npzfRKBis9VKP0tks5tN2WjgaJpZM4RrnND .

PropGit commented 6 years ago

I think that was the editor that doesn't require login first to get to, and was what we used initially to demonstrate the look and feel of Blockly on-the-fly. Apparently, it was needed for this share with link feature.

MatzElectronics commented 6 years ago

Yup.

On Wed, Jan 24, 2018 at 9:28 AM, Parallax Git Administrator < notifications@github.com> wrote:

I think that was the editor that doesn't require login first to get to, and was what we used initially to demonstrate the look and feel of Blockly on-the-fly. Apparently, it was needed for this share with link feature.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/1367#issuecomment-360210391, or mute the thread https://github.com/notifications/unsubscribe-auth/AS0quPFQsddG748Lev8jsOygrWbhjIsSks5tN2gNgaJpZM4RrnND .

MatzElectronics commented 6 years ago

More thoughts - I'd like to see the same endpoint that is used by the standard editor to retrieve a project take "key" as an optional argument, and if the key is valid, served the project (shared or not) That's how this is supposed to work anyway, so I think it's a matter of bringing that code into the endpoint that serves the project. Then, we don't need to maintain yet another editor page...

On Wed, Jan 24, 2018 at 9:29 AM, Matt Matz mmatz@parallax.com wrote:

Yup.

Matthew Matz | STEM/Robotics Educator Parallax Inc. | Direct: 916-625-3019 <(916)%20625-3019> | www.parallax.com | @MatzElectronics http://twitter.com/MatzElectronics | Licenses http://www.tspc.oregon.gov/lookup_application/LDisplay_Individual.asp?id=07080L3B270

On Wed, Jan 24, 2018 at 9:28 AM, Parallax Git Administrator < notifications@github.com> wrote:

I think that was the editor that doesn't require login first to get to, and was what we used initially to demonstrate the look and feel of Blockly on-the-fly. Apparently, it was needed for this share with link feature.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/1367#issuecomment-360210391, or mute the thread https://github.com/notifications/unsubscribe-auth/AS0quPFQsddG748Lev8jsOygrWbhjIsSks5tN2gNgaJpZM4RrnND .

PropGit commented 6 years ago

Yes, that sounds like a perfect solution.

zfi commented 6 years ago

My notes from this indicate that we should create the shared link at the time the project is created. The checkbox for sharing the link becomes an enable/disable toggle. The shared link should allow an anonymous user to view the project but not edit it. A logged in user can view it, edit it and save it. The save operation in this case is what we currently call a 'clone project' operation.

There should be (or used to be) two copies of the editor, one for demo/read-only and another for use by a logged in user. That's all I know about the editors.

MatzElectronics commented 6 years ago

@zfi, I'm going to split your last comment off into a new issue - creating the share key at the time of project creation and retrieving it via an endpoint

MatzElectronics commented 6 years ago

tested and verified. closing.

MatzElectronics commented 6 years ago

Reopening - @zfi and I are working on a different endpoint method for retrieving projectlink projects.

mrodriguez-parallax commented 6 years ago

Able to share link in another tab - no issues found

parallaxinc / BlocklyProp

Production and Demo no longer properly "Share project using link" #1367