Uploaded .svg code with user-defined code is collapsed but checked as if expanded

[PropGit]

While testing Issue #1662, I found that uploading a .svg that contained user-defined code results in said block(s) being collapsed, but checked as if they should be expanded. For example, this appears first:

Then this (if user unchecks the box next):

Then this (if user rechecks the box next):

I don't know if this is related to the updated code for Issue #1662 or not.

[PropGit]

Additionally, if the user imports and appends an .svg into a project with existing blocks of user-defined code, those blocks are collapsed (with the checkbox still checked).

The expected behavior is that existing blocks in the project remain as they are and that expanded (or collapsed) blocks within the .svg (the state they were in at the time of downloading to .svg) is maintained and restored upon upload replace/append.

[MatzElectronics]

@PropGit please re-test

[PropGit]

Retested - Failed in the same way as before.

Does the fix only require that Demo be refreshed, or does it require that I generate a new SVG? I'm using this project and the attached SVG.

Project97335.zip

[MatzElectronics]

It will require a new file, or at least reserve the original file before testing.

On Tue, May 28, 2019, 6:32 AM Parallax Git Administrator < notifications@github.com> wrote:

Retested - Failed in the same way as before.

Does the fix only require that Demo be refreshed, or does it require that I generate a new SVG? I'm using this project http://demo.blockly.parallax.com/blockly/projectlink?id=2216&key=a438d586-611a-4672-898f-c4299002f22f and the attached SVG.

Project97335.zip https://github.com/parallaxinc/BlocklyProp/files/3227880/Project97335.zip

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/1665?email_source=notifications&email_token=AEWSVOEPF375JZ25XJ55UB3PXUX7BA5CNFSM4HL2CBQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMEGDA#issuecomment-496517900, or mute the thread https://github.com/notifications/unsubscribe-auth/AEWSVOCXM2EXG4UPI5RJFATPXUX7BANCNFSM4HL2CBQA .

[PropGit]

I'm still getting the same failure, even if I... 1) replace an existing project with the original SVG, 2) Expand its user-defined code area, 3) Save the project, 4) Download a new blocks file (attached), and 5) append that new SVG into a different existing project.

User-Defined Code.zip

I've also cashless-refreshed.

Demo BlocklyProp version is: V1.1.457 Parallax © 2015 - 2019

[MatzElectronics]

Okay - I feel really bad about this - I didn't fully merge my code that should fix this. It should be in demo after 10:30. Again, I'm sorry about that.

On Tue, May 28, 2019 at 7:06 AM Parallax Git Administrator < notifications@github.com> wrote:

I'm still getting the same failure, even if I... 1) replace an existing project with the original SVG, 2) Expand its user-defined code area, 3) Save the project, 4) Download a new blocks file (attached), and 5) append that new SVG into a different existing project.

User-Defined Code.zip https://github.com/parallaxinc/BlocklyProp/files/3228035/User-Defined.Code.zip

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/1665?email_source=notifications&email_token=AEWSVOBJLNN6EHR7HTOE24TPXU353A5CNFSM4HL2CBQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMHSCQ#issuecomment-496531722, or mute the thread https://github.com/notifications/unsubscribe-auth/AEWSVOEY5ISBBK3D6M7DQXDPXU353ANCNFSM4HL2CBQA .

[PropGit]

Verified fixed.

Definitely requires a new SVG to be saved; I'm assuming with the user-defined code already expanded, for this to work. I didn't realize it was an issue with saving until we explored it in this thread.