Closed MatzElectronics closed 8 years ago
I think it's a fantastic proposal and would like to see it implemented. Be aware we introduce some possibilities of mixing these up with decimal numbers. After this, I think we must curb the feature addition and finish our documentation and BPSK using the Strings commands.
Is there a string type defined internally for these blocks?
Are the other blocks in the system prepared to accept / reject block connections that do not make sense, such as a string variable used in a comparison with an integer representation of the string ( "1" == 1)?
Perhaps you can issue a PR so we can see the code.
Yes, the blocks are set only to take strings where it expects strings and numbers where it expects numbers, so I don't think it will let you try something like "1" == 1. I'm finishing up testing to make sure the generated code is sound, and I'll submit a PR. Would it be possible to pull the current PR I have soon? That would save me from having to create another branch in my local repo.
Matthew Matz | STEM/Robotics Educator Parallax Inc. | Direct: 916-625-3019 | www.parallax.com | @M atzElectronics http://twitter.com/MatzElectronics
On Mon, Oct 3, 2016 at 10:17 AM, Jim Ewald notifications@github.com wrote:
Is there a string type defined internally for these blocks?
Are the other blocks in the system prepared to accept / reject block connections that do not make sense, such as a string variable used in a comparison with an integer representation of the string ( "1" == 1)?
Perhaps you can issue a PR so we can see the code.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/752#issuecomment-251166969, or mute the thread https://github.com/notifications/unsubscribe-auth/AS0quOKMyhRYUaLySfs0pglascdqu3hYks5qwTi-gaJpZM4KMbIG .
The PR was approved. Let's see what this thing can do.
Appears to be working so far! Will try to close this one out soon.
Tested, failed. All but the "get substring" block worked. Will submit a fix.
Tested and verified!
Any serious objects to doing this? (I have it all ready to go...)