search

parallaxinc / BlocklyProp

Blockly based visual programming editor for Propeller C
MIT License
44 stars 24 forks source link

String Blocks #752

Closed MatzElectronics closed 8 years ago

MatzElectronics commented 8 years ago

Any serious objects to doing this? (I have it all ready to go...) image

kgracey commented 8 years ago

I think it's a fantastic proposal and would like to see it implemented. Be aware we introduce some possibilities of mixing these up with decimal numbers. After this, I think we must curb the feature addition and finish our documentation and BPSK using the Strings commands.

pjewald commented 8 years ago

Is there a string type defined internally for these blocks?

Are the other blocks in the system prepared to accept / reject block connections that do not make sense, such as a string variable used in a comparison with an integer representation of the string ( "1" == 1)?

Perhaps you can issue a PR so we can see the code.

MatzElectronics commented 8 years ago

Yes, the blocks are set only to take strings where it expects strings and numbers where it expects numbers, so I don't think it will let you try something like "1" == 1. I'm finishing up testing to make sure the generated code is sound, and I'll submit a PR. Would it be possible to pull the current PR I have soon? That would save me from having to create another branch in my local repo.

Matthew Matz | STEM/Robotics Educator Parallax Inc. | Direct: 916-625-3019 | www.parallax.com | @M atzElectronics http://twitter.com/MatzElectronics

On Mon, Oct 3, 2016 at 10:17 AM, Jim Ewald notifications@github.com wrote:

Is there a string type defined internally for these blocks?

Are the other blocks in the system prepared to accept / reject block connections that do not make sense, such as a string variable used in a comparison with an integer representation of the string ( "1" == 1)?

Perhaps you can issue a PR so we can see the code.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/752#issuecomment-251166969, or mute the thread https://github.com/notifications/unsubscribe-auth/AS0quOKMyhRYUaLySfs0pglascdqu3hYks5qwTi-gaJpZM4KMbIG .

zfi commented 8 years ago

The PR was approved. Let's see what this thing can do.

MatzElectronics commented 8 years ago

Appears to be working so far! Will try to close this one out soon.

MatzElectronics commented 8 years ago

Tested, failed. All but the "get substring" block worked. Will submit a fix.

MatzElectronics commented 8 years ago

Tested and verified!