search

parallaxinc / BlocklyProp

Blockly based visual programming editor for Propeller C
MIT License
44 stars 25 forks source link

Add Favicon #760

Closed zfi closed 7 years ago

zfi commented 7 years ago

Implement a favicon for the site. @MatzElectronics has provided all of the needed files.

favicomatic.zip

zfi commented 7 years ago

@MatzElectronics I see a favicon on my safari browser on my iPhone and in the shortcut on the iPhone so it's working on at least two platforms.

MatzElectronics commented 7 years ago

Tested and verified!

MatzElectronics commented 7 years ago

@zfi - It is there for the main site, but as soon as you go into a project, it disappears.

zfi commented 7 years ago

This update has not been migrated to the beta site. You may be seeing is an artifact from browser caching. Open a private session or an incognito session to verify this.

MatzElectronics commented 7 years ago

Same with incognito window - favicon is present on the landing page, but disappears when I'm in the blockly workspace.

Matthew Matz | STEM/Robotics Educator Parallax Inc. | Direct: 916-625-3019 | www.parallax.com | @M atzElectronics http://twitter.com/MatzElectronics

On Wed, Oct 5, 2016 at 10:55 PM, Jim Ewald notifications@github.com wrote:

This update has not been migrated to the beta site. You may be seeing is an artifact from browser caching. Open a private session or an incognito session to verify this.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/760#issuecomment-251873568, or mute the thread https://github.com/notifications/unsubscribe-auth/AS0quHbS8rvaOmdfMxIRPBIXw9XrYFRqks5qxI1LgaJpZM4KPbc4 .

paragitadmin commented 7 years ago

Can you please try this test on another system, such as the dev VM? I have tried this on a number of mobile devices (iPhone, iPad, Android tablet) and on two more desktop systems and cannot reproduce the rouge favicon on the Demo site home page.

zfi commented 7 years ago

Can this issue be closed now?

wstodghill commented 7 years ago

@zfi - I get the favicon with the Demo Beta BlocklyProp (though when I go to project is disappears), but not get it at all with the Live Beta BlocklyProp (using Google Chrome). Went incognito too and no change... This is what I see...

fav

zfi commented 7 years ago

Good find on the favicon missing on the project page! It seems that there are multiple locations in code that are generating full pages without a global page template.

wstodghill commented 7 years ago

@zfi - thanks! Glad to be of help...

zfi commented 7 years ago

Favicon support files added to the header of remaining full pages. Result is available in Demo.

Note: Including as the first line in some full pages breaks the CSS for that page. This was noted on pages that rely on the Google Blockly library. All pages seem to render correctly without the declaration.

Closing the issue.