Closed PropGit closed 7 years ago
I did this in PR #74. I'll do some final testing/review before merging and closing this issue.
It looks like PR#74 includes a script that tags a number of files with a specific version number. I'm looking at this from an automated build process. Which file tracks the current version number?
@zfi - Not sure I understand the question. If you're asking which file an automated build process should check for an "official" version number, I'd say it's BlocklyPropClient.py.
@zfi
From this commit it appears that the version number is currently stored in three different places:
and with the recent enhancement of the Mac build/sign/packaging spec and scripts, it is also necessary for it to be placed in the Info.plist's CFBundleShortVersionString element (currently done automatically at signing/packaging time).
Until/unless we have a way to manage this better in the future, I think I should add a small sed script to the repo that will adjust the version in each of the necessary places in one step- something we can use like this, for example:
Do you agree with all of this, above?