parallaxinc / Parallax-ESP

Fork of http://git.spritesserver.nl/esphttpd.git/ with support for loading the Parallax Propeller
Other
12 stars 6 forks source link

error: implicit declaration of function #31

Open ClockLoop opened 5 years ago

ClockLoop commented 5 years ago

Not sure if its my paths or something? I cannot compile latest changes made here and others on the same date.

https://github.com/parallaxinc/Parallax-ESP/commit/5c340aecc3e66088bddb51ef852d3bac3c4ec8ec#r31248005

ClockLoop commented 5 years ago

I have commented out the offending code, and found that it generates similar errors in other files, that were all modified on the same date. I am not sure if I am missing something in my build environment? Can someone test the latest esp-open-sdk build with a build of the latest code here?

I am doing this on a raspberrypi 3 in latest version of raspbian. (no problem in the past doing this) Is "wifiSetCredentials" located in another file that I may be missing ? (an include file?) Any idea where this function is supposed to be declared? I tried to rebuild the esp-open-sdk multiple times, no help. I also searched the esp-open-sdk for that function and its no where to be found.

ClockLoop commented 5 years ago

It seems the latest commit here has introduced multiple issues for me. I documented the info in the forum. http://forums.parallax.com/discussion/169250/parallaxesp-wx8266-raspberrypi-esp-open-sdk-compile-info#latest

PropGit commented 5 years ago

Thank you. I've contracted someone to look into this for you.

On Sat, Nov 10, 2018, 4:10 PM ClockLoop <notifications@github.com wrote:

It seems the latest commit here has introduced multiple issues for me. I documented the info in the forum.

http://forums.parallax.com/discussion/169250/parallaxesp-wx8266-raspberrypi-esp-open-sdk-compile-info#latest

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/Parallax-ESP/issues/31#issuecomment-437632113, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNSjkqqljI0X4RZYplqqaMZnfAQDkayks5ut2rngaJpZM4YX441 .

ClockLoop commented 5 years ago
CC parallax/sscp-wifi.c
parallax/sscp-wifi.c: In function 'wifi_do_apset':
parallax/sscp-wifi.c:89:9: error: implicit declaration of function 'wifiSetCredentials' [-Werror=implicit-function-declaration]
         wifiSetCredentials(argv[1], argv[2], 1);
         ^
cc1: all warnings being treated as errors
Makefile:249: recipe for target 'build/parallax/sscp-wifi.o' failed
make: *** [build/parallax/sscp-wifi.o] Error 1

I tried to disable the -Werror flag. and I get the full output that ends in error with problems in code that was also recently changed.

:~/Parallax-ESP $ make
CC parallax/sscp-wifi.c
parallax/sscp-wifi.c: In function 'wifi_do_apset':
parallax/sscp-wifi.c:89:9: warning: implicit declaration of function 'wifiSetCredentials' [-Wimplicit-function-declaration]
         wifiSetCredentials(argv[1], argv[2], 1);
/home/pi/Parallax-ESP/parallax/sscp-wifi.c:76: undefined reference to `wifiSetCredentials'
collect2: error: ld returned 1 exit status
Makefile.ota:50: recipe for target 'build/httpd.user1.out' failed
make: *** [build/httpd.user1.out] Error 1

This is still a problem on OS Debian 64-bit. Perhaps a missing esp-open-sdk package, not sure which one.

Esp$ sudo apt-get install make unrar-free autoconf automake libtool gcc g++ gperf \
>     flex bison texinfo gawk ncurses-dev libexpat-dev python-dev python python-serial \
>     sed git unzip bash help2man wget bzip2
Reading package lists... Done
Building dependency tree       
Reading state information... Done
**Note, selecting 'libncurses-dev' instead of 'ncurses-dev'
Note, selecting 'libexpat1-dev' instead of 'libexpat-dev'**
autoconf is already the newest version (2.69-11).
automake is already the newest version (1:1.16.1-4).
bash is already the newest version (4.4.18-3.1).
bison is already the newest version (2:3.2.2.dfsg-1).
bzip2 is already the newest version (1.0.6-9).
libexpat1-dev is already the newest version (2.2.6-1).
flex is already the newest version (2.6.4-6.2).
gawk is already the newest version (1:4.2.1+dfsg-1).
g++ is already the newest version (4:8.2.0-2).
gcc is already the newest version (4:8.2.0-2).
git is already the newest version (1:2.20.0~rc2-1).
gperf is already the newest version (3.1-1).
help2man is already the newest version (1.47.8).
libtool is already the newest version (2.4.6-6).
make is already the newest version (4.2.1-1.2).
libncurses-dev is already the newest version (6.1+20181013-1).
python-serial is already the newest version (3.4-4).
python is already the newest version (2.7.15-3).
python-dev is already the newest version (2.7.15-3).
sed is already the newest version (4.5-2).
texinfo is already the newest version (6.5.0.dfsg.1-4+b1).
unrar-free is already the newest version (1:0.0.1+cvs20140707-4).
unzip is already the newest version (6.0-21).
wget is already the newest version (1.19.5-2).
0 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.

Esp$ sudo apt-get install libtool-bin
Reading package lists... Done
Building dependency tree       
Reading state information... Done
libtool-bin is already the newest version (2.4.6-6).
0 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.

I am only able to get it to compile with the previous commit. https://github.com/parallaxinc/Parallax-ESP/commit/5e32b8c2db9eda27632396f75cf4e6041b2048e5 5e32b8c2db9eda27632396f75cf4e6041b2048e5

PropGit commented 5 years ago

@ClockLoop - We just pushed a number of changes unrelated to this but should resolve the issue you had. Upon testing, we had to make clean followed by make and it worked. Can you test on your side and let us know if you still experience this issue? Current tip of master branch: https://github.com/parallaxinc/Parallax-ESP/commit/59521b7a6ad3552e3b3a0efc50a7c00b5c1f5c4b