parallaxinc / PropLoader

Parallax Propeller loader supporting both serial and wifi downloads
MIT License
27 stars 13 forks source link

Need a consistent success or failure response behavior #10

Closed PropGit closed 8 years ago

PropGit commented 8 years ago

There's a least one case where the response is not clear; did it succeed or did it fail?

For example, a successful module naming request (-n switch) simply returns control to the command line, without giving any notice. And a wireless discovery request (-W) gives no response when nothing is found. Though the discovery operation did finish properly, it represents a failure to find any module, yet the response is the same as a successful naming operation.

The lack of a success message is fine, but to be clear to the user, let's add a "No modules found" response to a discovery request that doesn't find any modules, and add a similar response behavior to any other operations that may present a similar conflicting response.

dbetz commented 8 years ago

I don't interpret finding no modules as an error. The request is to list all available modules and it seems to me that "none" is a successful response if there are none to be found.

PropGit commented 8 years ago

Under the circumstances, having the naming feature respond when successful (with the actual name applied to the module) will satisfy this concern.