search

parallaxinc / PropLoader

Parallax Propeller loader supporting both serial and wifi downloads
MIT License
27 stars 13 forks source link

Misleading error due to bad Wi-Fi Module address #17

Closed PropGit closed 7 years ago

PropGit commented 7 years ago

The command line:

proploader -i 1.2.3 flames-9600.elf

leads to:

error: wi-fi module firmware needs to be updated
Version string needs to begin with v1.
Current version string is (unknown)

but this is misleading and not a properly handled error case since the address (1.2.3) is not valid enough to even contact the device in the first place.

If the Wi-Fi Module can't be contacted, there is a distinctly different error message that should appear rather than something inferring that the module did responds but it's running the wrong firmware version.

PropGit commented 7 years ago

Tested with v1.0-8. Verified that the message is not misleading anymore. It still takes a very long time to appear because the timeout is long, but the "Opening file" message appears right away, which is fantastic and almost nullifies the long delay before final error message appears.

This issue is considered complete and closed.