search

parallaxinc / PropLoader

Parallax Propeller loader supporting both serial and wifi downloads
MIT License
27 stars 13 forks source link

Packet Driver : Corrected Coding error #45

Open bobbyl1066 opened 5 years ago

bobbyl1066 commented 5 years ago

There is a problem where this driver fails when used with a 10MHz clock. It may be that this coding error is responsible. I dont have the resources currently to test this. "bitticks" holds the value of how many ticks represent 1 bit and i think is used to adjust the driver to work with different clock frequencies. This is as i have shown it in the program this driver is derived from. "Full Duplex Serial Driver v1.1 Extended"

I am new to all this so dont know if right place for this. But if somebody could create a proploader.exe for windows so I can test this I would be greatful.

PropGit commented 5 years ago

@bobbyl1066 - Thanks. We've discovered that the failure to download with 10 MHz clock is due to support that wasn't finalized. Working on the solution now. @dbetz - Can you review the bitticks coding error here, code changes included, and determine if we should merge this PR?

dbetz commented 5 years ago

I'll try to do this later tonight. It's just a one line change but I have to remind myself of how the code works. In any case, the 10mhz downloads are a different problem. This packet driver is only used for writing to the SD card. It isn't used for downloads. I have a solution to the 10mhz download issue but I need to talk to Jeff Martin about the best approach. There are two possible solutions.

dbetz commented 5 years ago

I just looked at this code and it is not actually an error. The bitticks variable is set by the PASM code. You are correct though that the code is confusing. I'm modifying the input parameter called "baudrate" to contain a tick count before launching the COG that runs the PASM code. I should probably add a comment to that effect.