search

parallaxinc / PropLoader

Parallax Propeller loader supporting both serial and wifi downloads
MIT License
27 stars 13 forks source link

Confusing naming of loader variables (-D option) #47

Closed rstemmer closed 5 years ago

rstemmer commented 5 years ago

The naming scheme of the loader variables are not uniform which leads to misspelling and difficult to find bugs.

Current names:

 loader reset clkfreq clkmode fast-loader-clkfreq fastloader-clkmode baudrate loader-baud-rate fast-loader-baud-rate

Sometimes it is fast-loader, sometimes fastloader. Sometimes baudrate, sometimes baud-rate.

Making the use of "-" for all variables the same will improve the interface tremendously. To be backwards compatible it may be a good idea to just allow both variations, with and without "-".

dbetz commented 5 years ago

I just pushed a fix for this problem. The issue with "fastloader-clkmode" was just a help string problem. The variable is really called "fast-loader-clkmode" in the code. I've also added "baud-rate" as an option as well as keeping "baudrate" for backward compatibility. Thanks for reporting these problems.