search

parallaxinc / Propeller-Tool

Propeller Tool software for Windows
MIT License
9 stars 2 forks source link

Archive should not modify files #167

Open PropGit opened 2 years ago

PropGit commented 2 years ago

The Propeller Tool inherently converts non-Windows line endings (non-CR+LF) in a file to be Windows line-endings (CR+LF). An issue was raised with Archive in that it is changing LF-only (and also CR-only) line endings in a file to be CR+LF in the process of archiving.

Instead, the Archive feature should leave unopened files as they were (no line ending changes) for the archive; it can do whatever it needs to internally for compilation processes.

In addition, the Propeller Tool should maintain (or have an option to maintain) a file's line endings when saving.

This will help when source has been created by other platforms, such as Mac or Linux.

PropGit commented 2 years ago

The following was a note from conversation, saved here for future reference:

~To achieve what you suggest (which I agree with) I'll have to find a way to change this without changing its core behavior. The only question really, is what does it do if any of the files are modified but not saved (since a major feature of the Propeller Tool is the ability to use and compile any source independent of whether or not it has been saved after user-modification or even saved at all (ie: no file exists at all related to the source)). I want it to do something practical and reasonable without changing its inherent behavior. I think at this point, it means I need to implement a save-in-same-line-ending-format-that-it-loaded behavior for the Propeller Tool overall, which has been on my list of things to do, and ensure that the new nature effectively carries over to the archive process as well.