search

parallaxinc / solo

BlocklyProp without the wires
MIT License
5 stars 5 forks source link

Replace depricated Blockly.Variables.NAME_TYPE #389

Open zfi opened 4 years ago

zfi commented 4 years ago

Blockly.Variables.NAME_TYPE is deprecated. The recommended solution is to replace references to NAME_TYPE to VARIABLE_CATEGORY_NAME.

@MatzElectronics : Question: Is this a breaking change to any of our custom block definitions?

This is the comment in the current release of Blockly core...

/**
 * Constant to separate variable names from procedures and generated functions
 * when running generators.
 * @deprecated Use Blockly.VARIABLE_CATEGORY_NAME
 */
Blockly.Variables.NAME_TYPE = Blockly.VARIABLE_CATEGORY_NAME;
MatzElectronics commented 4 years ago

I don't think it's a problem - looks like a find-replace will be safe.

On Mon, Mar 23, 2020 at 10:34 AM Jim Ewald notifications@github.com wrote:

Assigned #389 https://github.com/parallaxinc/solo/issues/389 to @MatzElectronics https://github.com/MatzElectronics.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/solo/issues/389#event-3156308800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWSVOGXMKBUCLKGQ5JBW4TRI6MQXANCNFSM4LSBO5VA .