search

parallaxsecond / parsec-openssl-provider

Parsec OpenSSL Provider
Apache License 2.0
1 stars 1 forks source link

Add test crate #17

Closed gowthamsk-arm closed 6 months ago

gowthamsk-arm commented 6 months ago

Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com

tgonzalezorlandoarm commented 6 months ago

A general comment for our entire CI testing setup, not for this PR in particular: Should we be testing for MSRV? If so, we would be failing the CI with the current setup and I can open a PR for that

tgonzalezorlandoarm commented 6 months ago

Should we be testing for MSRV?

We should also probably define it. I think it should be 1.66.0 like parsec

gowthamsk-arm commented 6 months ago

Thanks for the comments.:) This is still a WIP PR. Will be pushing the cleaned-up version today.

tgonzalezorlandoarm commented 6 months ago

Sure, thanks :) I hope these help :)

tgonzalezorlandoarm commented 6 months ago

Seeing the CI failures, we should use https://docs.rs/env_logger/0.7.1/env_logger/fn.try_init.html instead of env_logger::init

tgonzalezorlandoarm commented 6 months ago

Could we please log errors in tests so that we can have more information?