Add references to RFC 4493 in comments about AesCMac.

parallaxsecond / rust-cryptoki

Rust wrapper for the PKCS #11 API, Cryptoki

https://docs.rs/cryptoki/

Apache License 2.0

75 stars 61 forks source link

Closed xaqq closed 10 months ago

xaqq commented 1 year ago

Hello, Thanks for merging previous PR exposing AesCMac.

Test vectors were coming from RFC 4493 so this commit clarifies that. (Also performs the test against the 4 available test data of the RFC)

wiktor-k commented 1 year ago

Ugh, it seems merging some other PR broke yours. Would you be able to resolve it? If not please say we can assist.

Thanks! :wave:

wiktor-k commented 1 year ago

maybe we can integrate Wycheproof in our tests, rather than having to manage our own list of test vectors.

Wow, this looks highly relevant! Thanks for linking.

gowthamsk-arm commented 10 months ago

@xaqq could you please rebase and resolve the conflicts so that we can merge the PR? :)

wiktor-k commented 10 months ago

Thanks for your time @xaqq!