Open NeilHanlon opened 3 months ago
I think this looks good. The lint you had to disabled should be accounted for in main so if you could rebase we'd proceed with this one.
Sorry for the delay - I guess it's holiday season :sweat_smile:
I'm happy with the patch, but as @wiktor-k says, would be good to rebase and re-enable the lint. Apologies for the long delay 🥲
All set. Sorry for the delay, and thank you!
I am wondering if you are missing adding the target in the GitHub workflow files (in .github). Compare with PRs doing similar changes for example #166 and #190. The CI might pass after that?
This change adds riscv64gc-unknown-linux-gnu bindings for cryptoki-sys crate and adds the target to ci.sh and regenerate_bindings.sh for future updates. This change will enable building the package for risvc in Fedora.
n.b., in order to build locally I disabled the
unused_qualifications
lint due to the following:If this change is not preferred or required, I can drop the hunk from the PR.