parallaxsecond / rust-tss-esapi

TSS 2.0 Enhanced System API (ESAPI) Rust wrapper
https://docs.rs/tss-esapi/
Apache License 2.0
88 stars 52 forks source link

Expanding UnMarshall + a few additions #410

Closed ionut-arm closed 1 year ago

ionut-arm commented 1 year ago

Hi all,

This PR contains two commits:

Obviously, also adding tests for the new stuff. The plan is to modify the remaining UnMarshall implementations to use unmarshall_offset as the "base" implementation, and unmarshall to just use that underneath.

Let me know if you'd like me to split out the 2nd commit - I've put them together in one PR since the 2nd depends on the 1st.

ionut-arm commented 1 year ago

I've had to update the _offset versions of the methods because they were hardcoded to u64, whereas the original size_t type is 32 bits on some platforms.

ionut-arm commented 1 year ago

Also it seems the log crate has been bumped beyond our MSRV underneath our feet, so we have to decide whether we want to bump the MSRV or fix the log version.

cc @gowthamsk-arm

Superhepper commented 1 year ago

Also it seems the log crate has been bumped beyond our MSRV underneath our feet, so we have to decide whether we want to bump the MSRV or fix the log version.

cc @gowthamsk-arm

It would be nice if we can lock it to a specific version but I am also completely ok with bumping MSRV.