search

parallaxsecond / rust-tss-esapi

TSS 2.0 Enhanced System API (ESAPI) Rust wrapper
https://docs.rs/tss-esapi/
Apache License 2.0
86 stars 51 forks source link

Fix create_ak for ECC keys #464

Closed ionut-arm closed 7 months ago

ionut-arm commented 10 months ago

Fixing the parameters for creating AKs in the Endorsement Hierarchy. The count value part of the EccScheme has been adjusted, and an empty EccPoint was added as unique identifier for the key.

ionut-arm commented 10 months ago

I'm curious now why that ecc_rsa test was supposed to fail 🤔

EDIT: nevermind, noticed the scheme... why does it work with swtpm, though....

wiktor-k commented 10 months ago

EDIT: nevermind, noticed the scheme... why does it work with swtpm, though....

I think a better explanation in the test would be a good idea. Also, instead of manual panic: #[should_panic] maybe even with expected...

Just throwing some random work ideas your way :sweat_smile:

Firstyear commented 9 months ago

What should we do to unblock this pr?

Superhepper commented 9 months ago

I do not think it is blocked I just think @ionut-arm has been busy and not been able to work on this. I think we decided to not use the #[should_panic]. So we are just waiting for him to re write the test to check that the correct error is being generated and this should be good to be merged.

Superhepper commented 7 months ago

@ionut-arm Tell me if you need any help with this. I can fix the tests for you if you like.

ionut-arm commented 7 months ago

@ionut-arm Tell me if you need any help with this. I can fix the tests for you if you like.

ok, finally got to this... @Firstyear - apologies for the long wait, I reckon this is ready to go (pending approval, of course)