Fixes problem with sign requiring a HashcheckTicket.

parallaxsecond / rust-tss-esapi

TSS 2.0 Enhanced System API (ESAPI) Rust wrapper

https://docs.rs/tss-esapi/

Apache License 2.0

86 stars 51 forks source link

Closed Superhepper closed 7 months ago

Superhepper commented 9 months ago

This fixes #475 by making the HashcheckTicket that was previously required in the sign context method optional instead. If it is None it is then internally converted into the HashcheckTicket version of the Null ticket before being converted to the corresponding TSS type. This has the benefit of removing the need to use the TSS type in order to create a Null ticket.

wiktor-k commented 9 months ago

I can't see the changes to fn sign here, were they committed?

I think you were looking for this line of code.

Superhepper commented 9 months ago

LGTM 👍 thanks!

This got me thinking that maybe we should review the other parameters and allow Nones there too 😅

I am not so sure about that. The other parameters have actual Null options which the ticket didn't.

Superhepper commented 7 months ago

Awesome, thanks!

Could you also add a review for this?