parallaxsecond / rust-tss-esapi

TSS 2.0 Enhanced System API (ESAPI) Rust wrapper
https://docs.rs/tss-esapi/
Apache License 2.0
85 stars 51 forks source link

Creates proper native type for TPMS_CONTEXT. #502

Closed Superhepper closed 5 months ago

Superhepper commented 6 months ago
Superhepper commented 6 months ago

I would like your thoughts on this draft. Like the structure, naming and documentation and such things.

ionut-arm commented 6 months ago

Also, btw, I wish we could drop the copyright years, just like https://github.com/curl/curl/pull/10205 (but it's an orthogonal matter).

@gowthamsk-arm @tgonzalezorlandoarm - do you have any info or points of reference for this?

tgonzalezorlandoarm commented 6 months ago

Also, btw, I wish we could drop the copyright years, just like curl/curl#10205 (but it's an orthogonal matter).

@gowthamsk-arm @tgonzalezorlandoarm - do you have any info or points of reference for this?

I only know that TF-M only updates for major changes: https://trustedfirmware-m.readthedocs.io/en/latest/contributing/contributing_process.html

wiktor-k commented 6 months ago

I only know that TF-M only updates for major changes: https://trustedfirmware-m.readthedocs.io/en/latest/contributing/contributing_process.html

It seems the guidelines are more generic or suited towards Gerrit powered workflows (as evidenced by "Add a Change-Id to the commit message").

It'd be cool to clarify with them the copyright years.

The links I sent have a lot of other projects, eg this Linux Foundation guidance:

Copyright The XYZ Authors. Copyright The XYZ Contributors. ... By using a common format, the project avoids having to maintain lists of names of the authors or copyright holders, years or ranges of years, and variations on the (c) symbol. This aims to minimize the burden on developers and maintainers as well as redistributors of the code...

Superhepper commented 5 months ago

I will abandon this PR for one without module name changes and the tpm2-tss library updates, see #507.