search

parallaxsecond / rust-tss-esapi

TSS 2.0 Enhanced System API (ESAPI) Rust wrapper
https://docs.rs/tss-esapi/
Apache License 2.0
85 stars 51 forks source link

Disables the clippy multiple_crate_versions lint error. #515

Closed Superhepper closed 5 months ago

Superhepper commented 5 months ago

In Rust version 1.77 clippy has begun reporting errors for when two versions of the same crate exists among the dependencies. In this case it is the syn crate for which there exists two versions. The reason for this is that the zeroize_derive crate updated the syn version after making a Rust Edition bump. So the ones using Rust Edition 2018 gets an older version of zeroize_derive which uses syn with major release version 1.

Superhepper commented 5 months ago

This looks okay but could you also add a comment about it here: https://github.com/parallaxsecond/rust-tss-esapi/blob/main/tss-esapi/Cargo.toml#L13

Since I guess when someone will be changing the msrv they may not look at other files.

Thanks!

I added a comment to the edition section.

Superhepper commented 5 months ago

Hmm, yes, maybe we should bump our edition...

I added a new issue for this and attached it to the 8.0.0 stabilization.