search

parallaxsecond / rust-tss-esapi

TSS 2.0 Enhanced System API (ESAPI) Rust wrapper
https://docs.rs/tss-esapi/
Apache License 2.0
85 stars 51 forks source link

implement bundled feature and improve windows support #523

Open uglyoldbob opened 4 months ago

uglyoldbob commented 4 months ago

This pull request adds a feature bundled. It builds the tpm2-tss library from source after fetching with git. The normal requirements for build the software apply.

The linux build needs all of the normal requirements for building tpm2-tss as described in their repository.

Windows builds require visual studio 2017, with the c2 clang option, visual studio build tools 10.0.17134.0. Openssl should be installed to C:\OpenSSL-v11-Win64

Superhepper commented 4 months ago

Excellent work. I will have a look at those errors when I get the time to see if we can get this merged.

uglyoldbob commented 4 months ago

I have a few changes required for bundled on linux remaining.

Superhepper commented 4 months ago

Only thing left for you to do is signing the commits.

uglyoldbob commented 4 months ago

The latest commit on the pull request should have signature on it now.

Firstyear commented 1 month ago

@ionut-arm @Superhepper Should we re-review this? This will assist me with MacOS development.

wiktor-k commented 1 month ago

@ionut-arm @Superhepper Should we re-review this? This will assist me with MacOS development.

Just FYI I'm not opposed to merging this but I've been unable to successfully test it in a reasonable time, both on a Windows machine locally and via CI (https://github.com/parallaxsecond/rust-tss-esapi/pull/524).

Firstyear commented 1 month ago

I've been trying to test it on macos, but there are issue in the tpm2-tss side, I need to double check it on linux.

Firstyear commented 1 month ago

@ionut-arm @Superhepper Should we re-review this? This will assist me with MacOS development.

Just FYI I'm not opposed to merging this but I've been unable to successfully test it in a reasonable time, both on a Windows machine locally and via CI (#524).

https://github.com/parallaxsecond/rust-tss-esapi/pull/531

My branch on top of this tests on linux and has it working :)

Superhepper commented 4 weeks ago

This needs to be rebased on the latest main.

Superhepper commented 2 weeks ago

@uglyoldbob It would be greate if you could rebase this on lastest from main so we could get it merged.

uglyoldbob commented 2 weeks ago

@Superhepper Ok I applied my changes to the latest on main, even with gpg signatures on the two commits. I couldn't figure out how to squash them into a single commit.

Superhepper commented 2 weeks ago

@Superhepper Ok I applied my changes to the latest on main, even with gpg signatures on the two commits. I couldn't figure out how to squash them into a single commit.

I usually squash commits using interactive rebase and remove all the signing thing from the comment. Then I sign the commit using amend.

wiktor-k commented 2 weeks ago

Ok I applied my changes to the latest on main, even with gpg signatures on the two commits. I couldn't figure out how to squash them into a single commit.

Just for the record when you do git rebase main (or something like that) you can also do git rebase -i main to start "interactive" rebase which would present you with a list of commits. If you mark the later ones as squash or fixup they'd be melded with previous ones automatically. Just FYI. :wave: