parallaxsw / OpenSTA

GNU General Public License v3.0
52 stars 23 forks source link

Add property-based filtering (`-filter` keyword arg) on all SDC `get_*` commands (+ DRY refactor) #72

Closed akashlevy closed 3 months ago

akashlevy commented 3 months ago

Creating a draft PR for this. Basic goal is to add -filter to all SDC get_* commands to match the behavior of commercial STA tools. I'll be following DRY principle as much as possible in my commits.

Need some input: how to deal with error codes? There's no room to squeeze in new codes, so right now I'm adding new ones by adding 2000 to the previous error code. Not sure if you have a preferred way of adding new codes into the mix. Another option is to remove some codes and have the filter_objs function have a single error code no matter which object type is being filtered.

Tasks:

akashlevy commented 3 months ago

All right, ready for review. Please let me know how to proceed regarding the error codes.

akashlevy commented 3 months ago

All revisions made. Also added error codes into messages.txt, let me know if it's ok

akashlevy commented 3 months ago

I updated your recently-added etc/FindMessages.tcl to support the filter_objs TCL expressions