Fix an issue with a deadlock for if(0) tasks

parallel-runtimes / lomp

Little OpenMP Library

Apache License 2.0

153 stars 17 forks source link

Fix an issue with a deadlock for if(0) tasks #35

Closed mjklemm closed 3 years ago

mjklemm commented 3 years ago

The issue was caused by the different counts for parent tasks, parent threads (= implicit task in OpenMP lingo) was not maintained in the right way. This commit attempts to fix this.

mjklemm commented 3 years ago

I have found another issue with the EPCC benchmarks that I will fix as part of this PR.

mjklemm commented 3 years ago

@JimCownie This is now ready for review.

JimCownie commented 3 years ago

LGTM. I have some fixes for the GOMP task interface code in the GOMP_task function which check (and abort) more cases there too. They are in the GCCSupport branch.