parallelchain-io / hotstuff_rs

Rust implementation of the HotStuff consensus algorithm.
38 stars 5 forks source link

Inconsistency: the meaning of option-wrapped values returned from BlockTree's methods #21

Closed karolinagrzeszkiewicz closed 1 year ago

karolinagrzeszkiewicz commented 1 year ago

Edit: this is not an issue, all "KVStore getters" return None when self.get(...) returns None, but throw an error when deserializing fails. This is correct since if self.get(...) succeeds, then deserialising should also succeed.