parallelchain-io / hotstuff_rs

Rust implementation of the HotStuff consensus algorithm.
34 stars 4 forks source link

`delete_branch` is non-tail-recursive #23

Closed karolinagrzeszkiewicz closed 5 months ago

karolinagrzeszkiewicz commented 8 months ago

delete_branch is non-tail-recursive and can result in stack overflow. Like with commit_block, long uncommitted branches should not occur, so stack overflow is unlikely, but to be fully safe and for the sake of good programming practice we might want to fix it.