paralleldrive / cuid

Collision-resistant ids optimized for horizontal scaling and performance.
Other
3.44k stars 123 forks source link

Modularize #25

Closed ericelliott closed 9 years ago

ericelliott commented 9 years ago

Please complete #24 first.

Stop using the hacky concat build.

.
└── cuid
    ├── build
    │   ├── client
    │   └── server
    ├── source
    │   ├── client
    │   └── server
    └── test
        ├── client
        └── server

Ignore build directory in diffs

You can ignore build files in diffs.

Create a .gitattributes file in the repo root:

build    -diff
therealklanni commented 9 years ago

What approach did you have in mind for the build? Browserify for client?

Additionally, are you wanting to use Babel and go full ES6 on this b***? :metal:

therealklanni commented 9 years ago

OK, I see that the boilerplate mentioned in #24 uses webpack, so I'll assume that.

ericelliott commented 9 years ago

Yep. Webpack! =)

therealklanni commented 9 years ago

Works pretty well with ES6. I'm not sure the minification is working, though. I'll have to look at the webpack docs on that.

Edit: resolved minification

therealklanni commented 9 years ago

@ericelliott Seems testling is experiencing technical difficulties. What do you want to use for client tests?

therealklanni commented 9 years ago

@ericelliott you originally had slug as a method on cuid, would you be OK with changing that so they can be imported independently (recommended)?

import { cuid, slug } from 'cuid'
ericelliott commented 9 years ago

Seems testling is experiencing technical difficulties. What do you want to use for client tests?

blue-tape (see boilerplate), run client tests on Sauce Labs