search

paralleldrive / cuid

Collision-resistant ids optimized for horizontal scaling and performance.
Other
3.44k stars 123 forks source link

package lib/ directory #85

Closed MarkHerhold closed 6 years ago

MarkHerhold commented 7 years ago

Fixes packaging issue mentioned in issue #84 where we excluded the lib directory. I tested that this now works by running npm pack and npm i <packed file>, and tested everything with a quick test script.

ericelliott commented 7 years ago

Can you also confirm that it will build and work properly when included in Webpack, Rollup, & Browserify bundles? Otherwise, it will have to wait for me to get some free time...

MarkHerhold commented 7 years ago

@ericelliott I can test Webpack and Browserify later today (never tried rollup), but I don't know why that would be a blocker for this PR.

ericelliott commented 7 years ago

I can test Webpack and Browserify later today (never tried rollup), but I don't know why that would be a blocker for this PR.

I want to make sure we have a complete, tested solution to #84 in this PR.

I've added a checklist in #84 to make it clear what "finished" looks like for this issue.

ericelliott commented 7 years ago

Any progress?