paralogical / glish

map all words to single-syllable version
MIT License
268 stars 18 forks source link

Complete TODO items and implement UI fixes #15

Open gezakerecsenyi opened 11 months ago

gezakerecsenyi commented 11 months ago

This fork is quite messy: all of my commits had to be rebased into one as I was hitting GitHub's 100MB file limit with outputs/random_generated_syllables_with_variations.json and had to convince it that the file never existed... I would highly suggest re-generating everything yourself to prevent any problems arising from the uploading of generated files to GitHub.

I'll do my best to explain my changes in this PR instead:

Test cases

Original

Type a sentence or paragraph in here in English to see its translation. This is some additional example text to demonstrate.

Old Glish

Type a stes or preft in here in glish to see its shlayr. This is some shuh plimdz to smud.

New Glish

Type a snuns or erg in here in Glish to see its talsh. this is some myih zul text to drayt.

paralogical commented 11 months ago

What a PR! Thank you so much for your work on this, it's really quite comprehensive. Apologies for my delay in responding to this. I'm very happy anyone would be willing to dig through and update my code so much :)

As you mention it's a lot of changes in one big chunk, so it's a little hard to review, but glancing through things generally look better. I appreciate that you extracted parameters into their own file.

My only concern is that there's something nice about leaving the original glish that closely matches the video. I know it already doesn't quite match exactly in some places, but it might be confusing if all the words are regenerated entirely. Even with all these improvements, I will say the example sentence is still pretty similarly tough to understand, and if the output is suddenly totally different, it's hard to use this tool consistently.

I might need to add some kind of versioning system so that baseline improvements can be made while still being possible to see the "original" Glish.