Fix: namespace limitation

paralus / cli

Command Line Interface tool for Paralus

https://www.paralus.io/

Apache License 2.0

8 stars 11 forks source link

Fix: namespace limitation #44

Closed mabhi closed 1 year ago

mabhi commented 1 year ago

Signed-off-by: mabhi abhijit.mukherjee@infracloud.io

What does this PR change?

This PR allows only valid characters those can be used when providing namespace name
Fixes 125

Does the PR depend on any other PRs or Issues? If yes, please list them.

Checklist

I confirm, that I have...

[x] Read and followed the contributing guide in CONTRIBUTING.md
[ ] Added tests for this PR
[ ] Formatted the code using go fmt (if applicable)
[ ] Updated documentation on the Paralus docs site (if applicable)
[x] Updated CHANGELOG.md

niravparikh05 commented 1 year ago

@mabhi when I try to execute below, It works fine and throws an error but does not spit of the cause properly. If a execute the same in debug mode I am able to see the validation kicking in. Can we ensure the cause in the error message during such cases is properly printed out ?

pctl update groupassociation "Namespace Admin" --associateproject default --roles NAMESPACE_READ_ONLY --namespace A123 --config ./admin@paralus.local.json

Error: unable to update group Namespace Admin, cause: could not complete operation update on resource Namespace Admin of type group

mabhi commented 1 year ago

@niravparikh05 can you provide replicating steps. As I tried with the command but it shows "Namespace A1234 is invalid"

niravparikh05 commented 1 year ago

@niravparikh05 can you provide replicating steps. As I tried with the command but it shows "Namespace A1234 is invalid"

thanks @mabhi, my bad ! my cli build was not up-to-date.. am able to verify the same now.