Added validation for project name

paralus / cli

Command Line Interface tool for Paralus

https://www.paralus.io/

Apache License 2.0

8 stars 11 forks source link

Added validation for project name #48

Closed hiteshwani29 closed 1 year ago

hiteshwani29 commented 1 year ago

What does this PR change?

This will fix issue #46

Does the PR depend on any other PRs or Issues? If yes, please list them.

Checklist

I confirm, that I have...

[x] Read and followed the contributing guide in CONTRIBUTING.md
[ ] Added tests for this PR
[x] Formatted the code using go fmt (if applicable)
[ ] Updated documentation on the Paralus docs site (if applicable)
[ ] Updated CHANGELOG.md

hiteshwani29 commented 1 year ago

please review this PR @niravparikh05 @akshay196 @mabhi

akshay196 commented 1 year ago

I believe as best practice we should let api handle such validations, cause introducing them to multiple places increases maintenance efforts as any change in the future needs to be changed everywhere.

Good point @niravparikh05 I agree. It's duplicate code at both places.

@hiteshwani29 Closing PR. Let us know if you think otherwise.