search

paralus / helm-charts

Helm charts for Paralus
https://www.paralus.io/
12 stars 15 forks source link

Contour CRDs are installing even when contour dependency is disabled #13

Open akshay196-rafay opened 2 years ago

akshay196-rafay commented 2 years ago

This issue is referring to the changes made in PR #14.

The contour subchart addition comes with its CRDs which are currently placed in the crds/ directory of this chart. The reason we kept crds in our own chart is to solve unable to recognize HTTPProxy kind error. (same error as mentioned in this issue)

These CRDs are installed independently whether a user enabled contour dependency or not. The --skip-crds option to helm install command skips installing crds. But currently we don't have option to manage CRDs based on enable/disable state of dependencies.

Potential solutions:

  1. Separate chart for CRDs as suggested here.
  2. Apply --skip-crds flag when installing chart with contour dependency turned off.
akshay196-rafay commented 2 years ago

Separate chart for CRDs as suggested here.

Due to this known issue of Helm, the CRDs will still be installed even when dependency if turned off.

Apply --skip-crds flag when installing chart with contour dependency turned off.

This is an easy solution I can think of right now. We will document this in the our chart installation.