Closed meain closed 2 years ago
I have made one more change, as of now we have values.dev-eks.yaml
which is applicable for eks and values.dev-generic.yaml
which is for all the other including kind. I think this probably is a better solution.
So it's either values-dev-eks.yaml
or values-dev-generic.yaml
.
Do we still need the note about the https setup and enabling kratos.development
as true
(the one that we have after installation)?
Or would you rather want a note that reads some thing like "If you're installing this in a production environment, please use values.yaml and configure the values mentioned here as required."
So it's either values-dev-eks.yaml or values-dev-generic.yaml .
Yup
Or would you rather want a note that reads some thing like "If you're installing this in a production environment, please use values.yaml and configure the values mentioned here as required."
This sounds good, lets add this in the docs.
What does this PR change?
Folks were getting stuck when
kratos.kratos.development
was not enabled by default. Suggesting this by default and using the namedev
should ideally help out this.@techmaharaj ~We can rework the docs and replace all references for
values.kind.yaml
andvalues.generic.yaml
tovalues.dev.yaml
and drop any mention of switching onkratos.kratos.development
.~ (see below)Checklist
I confirm, that I have...
CONTRIBUTING.md
CHANGELOG.md
helm-docs
to update docs for chart (if values.yaml file was changed)