Open PipGrylls opened 5 months ago
unittest is falling short here going to switch up to pytest
The setting with copy warning was being created by reset time in segment.
This is due to df[‘item’] or df.loc[‘item’] potentially causing problems. It didn’t here but its better to be cautious and not get into the habit of ignoring these warnings.
Another picky issue for me was the reassignment of the list in the loop, so I've replaced it with a map. Pro its cleaner and on smaller datasets we could see concurrency depending on how python wants to implement things, con there is potential that this increases memory requirement on larger datasets.
I suspect other memory issues will arise anyway when dealing with very large datasets, so if the feature works with the example datasets we have I would say it is ok for now.