PipGrylls commented 5 months ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] No style issues: $ python -m nox -s lint
[~] All tests pass: $ python -m nox -s unit examples integration
[x] Coverage is complete $ python -m nox -s coverage
[x] The documentation builds: $ python -m nox -s sphinx

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[N/A] Tests added that prove fix is effective or that feature works

brosaplanella commented 5 months ago

I think there is quite a bit of overlap between this PR and the other one, will review this once the other is merged.

brosaplanella commented 5 months ago

@PipGrylls can you merge develop into this? There will probably be some conflicts with thre README from the other PR.

PipGrylls commented 5 months ago

All good the README will have been flagged as more up to date in dv so not changed (if git worked properly)

paramm-team / pbdp

19 add a logger #20

Description

Type of change

Key checklist

Further checks